DOC-3371_V2: Remove general /docs/demo/ redirect causing catch-all issue for other redirects.#3987
Closed
kemister85 wants to merge 3 commits intomainfrom
Closed
DOC-3371_V2: Remove general /docs/demo/ redirect causing catch-all issue for other redirects.#3987kemister85 wants to merge 3 commits intomainfrom
/docs/demo/ redirect causing catch-all issue for other redirects.#3987kemister85 wants to merge 3 commits intomainfrom
Conversation
kemister85
requested review from
EkimChau,
ShiridiGandham,
tiny-james and
tjdett
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: DOC-3371 ref
Changes:
Looking at some redirects, it seem that by simply removing the general
/docs/demo/redirect, this should allow the specific/docs/demo/...redirects to work as expected.- currently they are not. The general/docs/demo/rule seems to be catching requests like/docs/demo/basic-example/before the specific rule runs, and depending on order and matching logic this is causing issues.What happens now:
✅
/docs/demo/basic-example/→/docs/tinymce/latest/basic-example/✅
/docs/demo/casechange/→/docs/tinymce/latest/casechange/✅ All other specific /docs/demo/... paths → their specific destinations
The specific redirects should now work without the catch-all interfering.
Pre-checks:
feature/<version>/,hotfix/<version>/,staging/<version>/, orrelease/<version>/.Review: