feat(sdk): DX-332 - Add timestamp field properties for metadata entities #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add convenience properties to expose createdAt and modifiedAt timestamp fields in the CatalogMetric entity model. These fields are already properly typed as datetime in the underlying API client following the OpenAPI spec updates that added schema annotations to timestamp fields. This change improves SDK usability by providing direct property access to timestamp metadata that was previously only accessible through json_api_attributes. Related to P005 - OpenAPI schema additions for timestamp fields Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add convenience properties to expose createdAt and modifiedAt timestamp fields in CatalogMetric entity model.
https://gooddata-jira-sandbox.atlassian.net/browse/DX-332
P005 - https://github.com/gooddata/gdc-nas/actions/runs/21868699246
The gdc-nas backend added proper OpenAPI schema definitions for createdAt and modifiedAt timestamp fields across multiple metadata model entities in STL-2296. The OpenAPI client has been regenerated with proper datetime types. This change adds convenience properties to the CatalogMetric entity model to expose these timestamp fields with proper typing, improving SDK usability by providing direct property access to timestamp metadata.
Changes
created_atproperty returningOptional[datetime]to CatalogMetricmodified_atproperty returningOptional[datetime]to CatalogMetricTesting
The properties access the underlying json_api_attributes which are already properly typed as datetime from the regenerated API client.
Related to P005 - OpenAPI schema additions for timestamp fields in gdc-nas.