Fix syntax highlighting for github pages (cont)#455
Merged
rossabaker merged 1 commit intotypelevel:developmentfrom Jun 29, 2023
Merged
Conversation
rossabaker
approved these changes
Jun 29, 2023
Member
rossabaker
left a comment
rossabaker
left a comment
There was a problem hiding this comment.
Thanks! If we could identify the versions that GitHub uses across the board, we could pin those in the build here and have less of this type of issue ... for as long as GitHub remains stable.
Member
|
Oh, #457 might address that... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #454, looks like the live site still has the default jekyll syntax highlighter enabled, conflicting with highlight.js. (Inspecting element on any piece of code on the site will show both
highlighter-rougeandhljs...)This is due to github-pages using a different version of jekyll (3.9.3) than the one defined in Gemfile. This fix actually fixes that for the live site.
See https://docs.github.com/en/pages/setting-up-a-github-pages-site-with-jekyll/about-github-pages-and-jekyll#syntax-highlighting.