Fix incorrect joint confidence colouring#1564
Draft
MaxPalmer-UH wants to merge 5 commits intodevelopfrom
Draft
Conversation
…in the render texture as they appear altered from the expected values
Restored omitted comments
…values_not_calculated_as_expected_due_to_colour_shift
MattFiler
reviewed
Nov 7, 2024
| @@ -1,3 +1,7 @@ | |||
|
|
|||
| // Tue this to log out the render colours seen by the camera in the render texture | |||
| #define LOGGING_RENDER_COLOURS | |||
Contributor
There was a problem hiding this comment.
Should this be disabled by default?
Turned off debugging and corrected typo.
Member
|
Are we expecting to merge this/improve on this further, or is this dead now? |
Member
|
Converting this PR back to a draft as it needs further work or closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the target colour palette values for joint confidence targets in the render texture as they appear altered from the expected values
Summary
When investigating the Lumi work, it appeared that the joint values calculated in the render texture, which are used as the target pixel colours for counting / calculating joint visibility do not match the source values used to render the capsule hands. This is unexpected but several days of looking for potential causes failed to determine the issue. This code contains new target values, based on the pixel colours in the rendertexture and also some code that can be used to log out the colours, which is useful in checking if this is an issue that occurs across multiple systems/versions/platforms.
Contributor Tasks
Test Cycle
Link to the test cycle here.
Reviewer Tasks
Related JIRA Issues
If this MR closes any JIRA issues list them below in the form
Closes PROJECT-#Pull Request Templates
Switch template by going to preview and clicking the link - note it will not work if you've made any changes to the description.
You are currently using: default.md
Note: these links work by overwriting query parameters of the current url. If the current url contains any you may want to amend the url with
&template=name.mdinstead of using the link. See query parameter docs for more information.