Under annotations

[hflexgrig]

Here in this pr I'll try to bring under annotations ( \underbrace, \underbracket ) with display and latex support

[hflexgrig]

@Happypig375 Implementation might take a few days, especially display part is a quite complicated, on a Mathify I've spent more then week :) I'll do a small commits, please track all my commits for better quality and quick fixes.

[hflexgrig]

@Happypig375 Just ran the dotnet format command on a core CSharpMath.csproj , and it broght changes on 53 files, similar to what it changed that you commented already. Lats first resolve problem with autoformatting. I'm using vs code ide, which ide do you use and which formatters? don't want to bring lots of formatting changes on my pr

[Happypig375]

@hflexgrig I just use Visual Studio and it formats things on the fly. You can pull request all the auto formatting. The unnecessary space should be fixed though.

[hflexgrig]

Almost...

[hflexgrig]

@Happypig375 I think finished with basic implementation, lats fixup this one and merge, then adding rest of the annotations would be much easier! this was the most difficult part.

[Happypig375]

@hflexgrig Tell me when you let me take this PR over

[hflexgrig]

@hflexgrig Tell me when you let me take this PR over

I think we can merge it now, if no additional fixups required from your side

[Happypig375]

There is at least a big red cross that needs fixing. Also, your NotImplementedException which prevents Display tests from being added.

[hflexgrig]

There is at least a big red cross that needs fixing. Also, your NotImplementedException which prevents Display tests from being added.

Hmm... running dotnet format --exclude Typography breaking the unittests.

dotnet format --exclude Typography Warnings were encountered while loading the workspace. Set the verbosity option to the 'diagnostic' level to log warnings. Unable to fix CA1416. No associated code fix found. Unable to fix AVP1001. No associated code fix found.

[Happypig375]

@hflexgrig It does that when encountering any warning. Warnings are disregarded by the format check for now.

[Happypig375]

I can commit some tests when you're done with committing.

[hflexgrig]

I can commit some tests when you're done with committing.

Yes please, go ahead

[Happypig375]

See #250 PR on this PR - hflexgrig#1

[hflexgrig]

See #250 PR on this PR - hflexgrig#1

That one could be merged into master, and then master into my branch, so that pr changes are clear.

[Happypig375]

@hflexgrig Then you'll have to wait until #250 is merged.

[hflexgrig]

@hflexgrig Then you'll have to wait until #250 is merged.

Yes sure, at least we know it fixes the build issues.

[Happypig375]

Is the display on iOS somehow different from the one on Windows?

[Happypig375]

@hflexgrig The measures for the underbrace don't look right. When there is subscript content, they are measured with extra spacing below.

You can run CSharpMath.Rendering.Tests to confirm this.

[hflexgrig]

I'd like to do adjustments later, after adding other annotations like \underbracket. Regarding windows, I don't have any windows machine, but it is wierd that it different that ios.

[Happypig375]

I think the Windows issue is related to the wrong display measurements, maybe you set ascent and descent incorrectly. On Windows, the allocated GraphicsView canvas is larger than the view size unlike other platforms. The display is drawn on the math view using a position depending on display ascent and descent, and in this case the display seems to be anchored at the bottom left of the larger canvas.

I'll publish a pre-release without this feature merged then.

[Happypig375]

Running CSharpMath.Core.Example to view the underbrace also shows the subscript being way below where it should be.

[Happypig375]

I understand the want to keep PRs small and manageable, but known bugs (i.e. wrong measures) should be fixed before merging.