Allow a specific value for the pip version, instead of upgrading virtualenv to latest#558
Allow a specific value for the pip version, instead of upgrading virtualenv to latest#558GusPriceAtlassian wants to merge 2 commits intovoxpupuli:masterfrom
Conversation
…ser set value (ie pip==9.0.3)
kenyon
left a comment
kenyon
left a comment
There was a problem hiding this comment.
Commit message should be reformatted. https://chris.beams.io/posts/git-commit/
| [](https://github.com/voxpupuli/puppet-python/blob/master/LICENSE) | ||
| [](https://travis-ci.org/voxpupuli/puppet-python) | ||
| [](https://forge.puppetlabs.com/puppet/python) | ||
| [](https://forge.puppetlabs.com/puppet/python) | ||
| [](https://forge.puppetlabs.com/puppet/python) | ||
| [](https://forge.puppetlabs.com/puppet/python) | ||
| This module is a fork of https://github.com/voxpupuli/puppet-python with modification to | ||
| manifests/virtualenv.pp to support specific pip versions. |
| $path = [ '/bin', '/usr/bin', '/usr/sbin', '/usr/local/bin' ], | ||
| $cwd = undef, | ||
| $timeout = 1800, | ||
| $pip_version = '--upgrade pip', |
There was a problem hiding this comment.
can you please add a datatype for the new parameter?
There was a problem hiding this comment.
please also document the parameter in the header
|
can you please rebase against our latest master branch ( do not merge master into your feature branch, please do a rebase). We fixed most of the linter warnings you see in the test runs. if you've any questions feel free to join our IRC channel #voxpupuli on freenode. |
|
Dear @GusPriceAtlassian, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
3 participants
Pull Request (PR) description