Wire deterministic context-menu close signaling across Electron and renderer

[Copilot]

Context-menu opens previously produced renderer callbacks only on selection (0 or 1 events). This change makes the lifecycle deterministic: every menu open now emits exactly one completion signal, with null on cancel and item id on selection.

• Main process: single terminal callback per popup

  • Updated emain/emain-menu.ts to use menu.popup({ callback }).
  • Tracks whether a menu item click occurred during the popup.
  • Emits contextmenu-click: null only when the menu closes without selection.
  • Suppresses duplicate close events when a click already fired.

• Preload + API typing: nullable context-menu callback payload

  • Updated preload bridge and frontend/types/custom.d.ts so:
    • onContextMenuClick now accepts (id: string | null) => void.
  • Keeps existing channel semantics while allowing explicit cancel signal.

• Renderer context menu model: close/select/cancel hooks

  • Extended showContextMenu with optional opts:
    • onSelect?: (item) => void
    • onCancel?: () => void
    • onClose?: (item: MenuItem | null) => void
  • Execution order on selection:
    1. original item click
    2. onSelect
    3. onClose
  • Execution order on cancel:
    1. onCancel
    2. onClose(null)

• Targeted behavior tests

  • Expanded frontend/app/store/contextmenu.test.ts to verify:
    • singleton wiring still initializes once,
    • selection path ordering (click -> onSelect -> onClose),
    • cancel path ordering (onCancel -> onClose(null)).

ContextMenuModel.getInstance().showContextMenu(menu, e, {
    onSelect: (item) => { /* after item.click */ },
    onCancel: () => { /* close without selection */ },
    onClose: (itemOrNull) => { /* always called */ },
});

Not applicable — this is a behavioral/API flow change in native context menu lifecycle rather than a visual UI update.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[cloudflare-workers-and-pages]

Deploying waveterm with    Cloudflare Pages

Latest commit:	f302fa7
Status:	✅  Deploy successful!
Preview URL:	https://49738305.waveterm.pages.dev
Branch Preview URL:	https://copilot-update-context-menu.waveterm.pages.dev

View logs

[kiloconnect]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (5 files)

• emain/emain-menu.ts - Context menu callback tracking implementation
• emain/preload.ts - Type signature update for null support
• frontend/app/store/contextmenu.ts - Lifecycle callback support
• frontend/app/store/contextmenu.test.ts - Comprehensive test coverage
• frontend/types/custom.d.ts - Type definition update

---

Review Notes

This PR adds lifecycle callbacks (onSelect, onCancel, onClose) to the context menu system. The implementation is well-designed:

✅ Proper state tracking - menuState.hasClick correctly tracks menu item selection
✅ Type safety - Consistent string | null types across all layers
✅ Callback ordering - Correct sequence: item.click() → onSelect() → onClose()
✅ Error handling - Early returns for invalid webContents
✅ Test coverage - Comprehensive tests validate both selection and cancellation paths
✅ Cleanup - Proper clearing of handlers and activeOpts

No bugs or issues detected.