Add checks for direct buffer, texture, attachment support#552
Merged
greggman merged 2 commits intowebgpu:mainfrom Jan 22, 2026
Merged
Add checks for direct buffer, texture, attachment support#552greggman merged 2 commits intowebgpu:mainfrom
greggman merged 2 commits intowebgpu:mainfrom
Conversation
Collaborator
Author
|
I snuck this into I could
I worry that checking in each sample will lead other devs to check. I think we'd prefer they don't check and just use this new way and tell users to upgrade. Otherwise, these checks will likely propagate for years. |
Firefox and Chrome have supported this for 3-4 months or more. Safari started supporting it in 2025-12 as of Tahoe 26.2. We're planning to switch the samples to use this new more convenient method but want to be able to tell users on older browsers to update their browsers.
greggman
force-pushed
the
add-warning-for-missing-features
branch
from
1d1e657 to
a20bac4
Compare
kainino0x
approved these changes
Jan 22, 2026
Collaborator
kainino0x
left a comment
kainino0x
left a comment
There was a problem hiding this comment.
lgtm, I prefer option 2 (just rename)
Collaborator
Author
|
renamed |
kainino0x
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox and Chrome have supported this for 3-4 months or more. Safari started supporting it in 2025-12 as of Tahoe 26.2. We're planning to switch the samples to use this new more convenient method but want to be able to tell users on older browsers to update their browsers.