Handle editing of partially selected lists#813
Open
satsuper wants to merge 8 commits intowebodf:masterfrom
Open
Handle editing of partially selected lists#813satsuper wants to merge 8 commits intowebodf:masterfrom
satsuper wants to merge 8 commits intowebodf:masterfrom
Conversation
|
Build succeeded. |
added 8 commits
September 19, 2014 11:17
These operations work on the level of top level lists only Added tests for the new operations and changed the op test code to parse any op parameter containing "length" or "position" in the name as an integer
This handles transforms between Add/Remove list and other operations that modify the number of steps in the document. There are some unresolved conflicts with merging paragraphs and adding lists that return null as the transform result which required merge and split operations on lists to be resolved correctly. Added tests for the new parts of the op transform matrix and changed the op transform test code to parse any op parameter containing "length" or "position" in the name as an integer.
satsuper
force-pushed
the
merge-split-list
branch
from
a4b34bb to
4452a19
Compare
|
Build succeeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues the work started by PR #674 on list editing. The aim of this is to add support for partially selecting a list and then only removing the list on the selected paragraphs. This will also support switching partial selections between numbered and bulleted styles.
TODO
[x] Operations for merging and splitting lists
[ ] Refactor out duplicate position verification logic (might move this to another PR)
[ ] Update list controller to use new operations to enable editing partial list selections
[ ] Add operational transforms for new ops
[ ] Fix unsolved OT conflicts from add and remove list ops