Adds support to Native Window Menu in multiple platforms.#31
Open
abner wants to merge 2 commits intowebviewjs:mainfrom
Open
Adds support to Native Window Menu in multiple platforms.#31abner wants to merge 2 commits intowebviewjs:mainfrom
abner wants to merge 2 commits intowebviewjs:mainfrom
Conversation
…he CPU usage from above 50% to less than 1% in a MacBookPro M4 Pro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented a support for menu, as, mainly in MacOS, the absence of the menu configured makes the use of the webview poor, as the user can't trigger easily and natively some operations like Copy (Command + C), Paste (Command + V), Cut (Command +X), SelectAll (Command + A) and Quit (Command + Q), through the usual shortcuts.
Although, this implementation still lacks the feature to allow to override this native menu with the developer own override of the this native items label, text and own accelerators (shortcuts).
But, anyway, it could be improved, and as the menu feature itself is absence at this point, maybe it would be a matter of accepting this PR and working from there, or iterate it here during the review of this PR.
I tested it locally in my Macbook, but I couldn't verify it yet in the other Platforms (Linux and Windows).