Open
Conversation
the function should return the action that it ran
Author
|
@patapizza Can you review this? |
Member
|
@harisvsulaiman Curious why do you need the action just run? |
Author
|
@patapizza it made sense to to return it since all other values are returned. And I think I can write action names from the composer to include some params as part of the name which I could parse to modify behaviour on our end. Which would enable we two pass values without context. |
|
@patapizza Could you do a release with this change? |
magnusburton
approved these changes
Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the function should return the action that it ran