Open
Conversation
ejohnstown
force-pushed
the
rxd-fix
branch
2 times, most recently
from
69e1d55 to
fc39ced
Compare
There was a problem hiding this comment.
Pull request overview
Fixes handling around “channel RX’d” (WS_CHAN_RXD) and agent setup paths, primarily to improve forwarding behavior in the echoserver and make agent-related code compile cleanly.
Changes:
- Treat
WS_CHAN_RXDas a successful outcome for returninglastRxIdfromwolfSSH_worker(). - Silence unused-parameter warnings in agent stubs.
- Fix echoserver agent UNIX-socket setup flow so it proceeds correctly after
snprintf()and simplifies thesocket()error assignment.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/ssh.c |
Returns channelId not only on WS_SUCCESS but also on WS_CHAN_RXD so callers can identify the channel that received data. |
src/agent.c |
Adds WOLFSSH_UNUSED(agent) to avoid unused-parameter warnings when logging is compiled out. |
examples/echoserver/echoserver.c |
Corrects agent local setup flow after snprintf() and adjusts UNIX-socket bind/setup logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1. Fix a couple unused variable warnings. 2. In wolfSSH_AGENT_DefaultActions(), fix comparison to the result of snprintf() treating normal result as an error. Reset the return code for the error state of the socket() command. Remove the size variable and just use sizeof() the sockaddr_un. Better cleanup of agent startup failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.