feat: implement Bible reader view for Android#39
Merged
sidorchukandrew merged 3 commits intomainfrom Feb 27, 2026
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
Greptile SummaryThis PR replaces the Android Bible reader view placeholder with a real implementation that delegates to the Kotlin SDK's
Confidence Score: 2/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant RN as React Native
participant Module as RNBibleReaderViewModule
participant View as YVPBibleReaderView
participant Compose as Jetpack Compose
participant SDK as BibleReader (Kotlin SDK)
RN->>Module: Register "BibleReaderView"
RN->>View: Create view with props
Note over View: Props initialized to null
RN->>View: Set appName, signInMessage, versionId, bookUSFM, chapter, etc.
Compose->>View: Content(modifier)
View->>View: bibleReference()
alt verseStart & verseEnd set
View->>SDK: BibleReference(versionId, bookUSFM, chapter, verseStart, verseEnd)
else hasReference == true
View->>SDK: BibleReference(versionId, bookUSFM, chapter, verse?)
else no reference
View->>SDK: null
end
View->>SDK: BibleReader(appName, signInMessage, bibleReference)
Last reviewed commit: 22e36fd |
android/src/main/java/com/youversion/reactnativesdk/views/YVPBibleReaderView.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/youversion/reactnativesdk/RNBibleReaderViewModule.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/youversion/reactnativesdk/views/YVPBibleReaderView.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/youversion/reactnativesdk/views/YVPBibleReaderView.kt
Show resolved
Hide resolved
bmanquen
reviewed
Feb 19, 2026
android/src/main/java/com/youversion/reactnativesdk/views/YVPBibleReaderView.kt
Show resolved
Hide resolved
android/src/main/java/com/youversion/reactnativesdk/views/YVPBibleReaderView.kt
Outdated
Show resolved
Hide resolved
Collaborator
Author
Collaborator
Collaborator
Author
bmanquen
approved these changes
Feb 27, 2026
Collaborator
bmanquen
left a comment
There was a problem hiding this comment.
Approved, assuming the UI differences will be resolved when we update the Android SDK version.
jhampton
pushed a commit
that referenced
this pull request
Feb 27, 2026
|
🎉 This PR is included in version 0.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Description
This implements the Bible reader view for Android. The Kotlin SDK does not have all of the reader implemented natively yet, but this is enough for us to wrap it and expose it. Any changes made to the Kotlin side should not really affect the RN SDK.
Type of Change
feat:New feature (non-breaking change which adds functionality)fix:Bug fix (non-breaking change which fixes an issue)docs:Documentation updaterefactor:Code refactoring (no functional changes)perf:Performance improvementtest:Test additions or updatesbuild:Build system or dependency changesci:CI configuration changeschore:Other changes (maintenance, etc.)Checklist