WestMidlands| SDC NOV 2025 |Sara Tahir| Sprint 2 | Improve with caches#119
Open
SaraTahir28 wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
WestMidlands| SDC NOV 2025 |Sara Tahir| Sprint 2 | Improve with caches#119SaraTahir28 wants to merge 3 commits intoCodeYourFuture:mainfrom
SaraTahir28 wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjyuan
reviewed
Feb 22, 2026
There was a problem hiding this comment.
Array creation is a relatively costly operation.
From line 42, we know coins can only be one of the following 9 arrays:
[200, 100, 50, 20, 10, 5, 2, 1]
[100, 50, 20, 10, 5, 2, 1]
[50, 20, 10, 5, 2, 1]
...
[1]
[]
We could further improve the performance if we can
- avoid repeatedly creating the same sub-arrays at line 42 (e.g. use another cache), and
- create key as (total, a_unique_integer_identifying_the_subarray) instead of as (total, tuple of coins)
- There are only a small number of different subarrays. We can easily assign each subarray a unique integer.
Author
There was a problem hiding this comment.
- Thanks for the suggestion . I’ve updated the implementation so I no longer slice the coins list. Instead, I pass a start_index through the recursion, which avoids creating new subarrays entirely.
- I also switched the cache key to (total, start_index) rather than (total, tuple(coins)). This gives each of the 9 possible sub‑arrays a unique integer “identity” automatically, without needing a separate mapping
- This keeps the logic the same but removes the repeated list allocations and makes the memoisation faster and cheaper.
|
Changes look good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Improved the performance of both the fibonacci and making_change functions by adding caching (memoisation) to avoid recalculating the same subproblems.
Questions
I dont have any questions.