generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 26
WestMidlands| SDC NOV 2025 |Sara Tahir| Sprint 2 | Improve with caches #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SaraTahir28
wants to merge
3
commits into
CodeYourFuture:main
Choose a base branch
from
SaraTahir28:feature/Improvecaches
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,17 @@ | ||
| #initialising a dictionary to store a copy of what we already know or have already computed | ||
| #caching reduces the fibonacci time complexity from exponential to linear. | ||
| cache = {} | ||
|
|
||
| def fibonacci(n): | ||
| if n <= 1: | ||
| if n in cache: | ||
| return cache[n] | ||
|
|
||
| if n <= 1: #when n is 0 or 1, we don’t need to calculate anything,just return th known value | ||
| return n | ||
| return fibonacci(n - 1) + fibonacci(n - 2) | ||
|
|
||
| result = fibonacci(n - 1) + fibonacci(n - 2) | ||
|
|
||
| #saving result in our dict before returning | ||
| cache[n] = result | ||
| return result | ||
|
|
57 changes: 42 additions & 15 deletions
57
Sprint-2/improve_with_caches/making_change/making_change.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,59 @@ | ||
| from typing import List | ||
|
|
||
| cache = {} | ||
|
|
||
| def ways_to_make_change(total: int) -> int: | ||
| """ | ||
| Given access to coins with the values 1, 2, 5, 10, 20, 50, 100, 200, returns a count of all of the ways to make the passed total value. | ||
|
|
||
| For instance, there are two ways to make a value of 3: with 3x 1 coins, or with 1x 1 coin and 1x 2 coin. | ||
| """ | ||
| return ways_to_make_change_helper(total, [200, 100, 50, 20, 10, 5, 2, 1]) | ||
| coins = [200, 100, 50, 20, 10, 5, 2, 1] | ||
| return ways_to_make_change_helper(total, coins, 0) | ||
|
|
||
|
|
||
| def ways_to_make_change_helper(total: int, coins: List[int]) -> int: | ||
| def ways_to_make_change_helper(total: int, coins: List[int],start_index: int) -> int: | ||
|
|
||
| """ | ||
| Helper function for ways_to_make_change to avoid exposing the coins parameter to callers. | ||
| """ | ||
| if total == 0 or len(coins) == 0: | ||
| #We found one valid way if its an exact match. | ||
| if total == 0: | ||
| return 1 | ||
| # No coins left to try as we moved past the end of the list | ||
| if start_index >= len(coins): | ||
| return 0 | ||
|
|
||
| # Cache key now uses (total, start_index) instead of hashing the whole coin list | ||
| key = (total, start_index) | ||
| if key in cache: | ||
| return cache[key] | ||
|
|
||
| ways = 0 | ||
| for coin_index in range(len(coins)): | ||
| coin = coins[coin_index] | ||
| count_of_coin = 1 | ||
| while coin * count_of_coin <= total: | ||
| total_from_coins = coin * count_of_coin | ||
| if total_from_coins == total: | ||
| ways += 1 | ||
| else: | ||
| intermediate = ways_to_make_change_helper(total - total_from_coins, coins=coins[coin_index+1:]) | ||
| ways += intermediate | ||
| count_of_coin += 1 | ||
|
|
||
| # Try using the current coin 1,2,3... times as long as we don't exceed the total. | ||
| coin = coins[start_index] | ||
| count_of_coin = 1 | ||
|
|
||
| while coin * count_of_coin <= total: | ||
| total_from_coins = coin * count_of_coin | ||
|
|
||
| if total_from_coins == total: | ||
| # if exact match then one valid way | ||
|
|
||
| ways += 1 | ||
| else: | ||
| # Remaining total, and move to the next coin (no slicing!) | ||
| intermediate = ways_to_make_change_helper( | ||
| total - total_from_coins, | ||
| coins, | ||
| start_index + 1 | ||
| ) | ||
| ways += intermediate | ||
|
|
||
| count_of_coin += 1 | ||
|
|
||
| # Also consider the case where we skip this coin entirely | ||
| ways += ways_to_make_change_helper(total, coins, start_index + 1) | ||
|
|
||
| cache[key] = ways | ||
| return ways |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Array creation is a relatively costly operation.
From line 42, we know
coinscan only be one of the following 9 arrays:We could further improve the performance if we can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.