Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 1 | Bug Report: Extra long blooms? by HassanOHOsman · Pull Request #147 · CodeYourFuture/Module-Legacy-Code

HassanOHOsman · 2026-02-17T14:38:59Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

This PR fixes AS's extra long bloom bug by ensuring it respects the 280-character limit. Changes include:

Trim bloom content on submission: Users cannot post blooms longer than 280 characters.
Trim bloom content when rendering: Any existing or backend-provided blooms are capped at 280 characters in the UI

OracPrime

Convince me of your approach (good luck!) or make it fail not trim!

OracPrime · 2026-02-19T22:32:43Z

front-end/components/bloom-form.mjs

  const originalText = submitButton.textContent;
  const textarea = form.querySelector("textarea");
-  const content = textarea.value.trim();
+  const content = textarea.value.trim().slice(0, 280);


I'm not convinced. Should too long a bloom fail, or should you truncate it and accept it? I think it should fail.

To be honest, at the time I was in two minds whether or not to handle the too long bloom with an error which lead to it not being submitted. However, somehow eventually I resorted to chopping the extra characters. I perhaps thought this approach would me more ideal since it's already published bloom.

I understand now I have to fail it altogether. I will working on it. Thank you.

… will later be replaced with a logic that fails the bloom altogeather.

… the console. Use it to skip it while fetching all blooms from backend

…en blooms fetched from backend

HassanOHOsman · 2026-02-20T21:08:43Z

AS bloom - the one over 280 character is now hidden. Not sure if it's the ideal approach but I did use the bloom id from the error message showed up on my browser and used it to skip over the culprit bloom when blooms are being fetched.

HassanOHOsman · 2026-02-20T21:12:16Z

I understand very well that, ideally, there should've been a condition that'd check if a bloom was over 280 characters and if so it'd be skipped over. Having said that this just didn't work for some reason when i did it.

…acters instead.

HassanOHOsman · 2026-02-20T21:26:27Z

UPDATE: Well, it has worked now - I replaced the bloom ID-based logic to a conditional logic that checks if bloom is over 280 char and skips over it if that's the case. I had to disconnect from all ports and reconnect again.

OracPrime

You seem to be prevent overlong blooms being displayed when reading them back from the database. This is the wrong time to be doing it. You need to prevent overlong blooms being added.

I'm also concerned that your code refers to a non-existent function. Have you tested this?

OracPrime · 2026-02-21T17:38:21Z

backend/data/blooms.py


 def get_bloom(bloom_id: int) -> Optional[Bloom]:
-    with db_cursor() as cur:
+    with db_get_bloomcursor() as cur:


This function doesn't exist does it?

I have not implemented unit tests. However, i have manually tested what i did through the browser. Everything seemed fine, the culprit bloom wasn't/isn't displayed (which - I now know - is not the right way to do it), clicked on different buttons, sent a bloom so basically did different operations and no error messages showed up whatsoever in the console. I've attached screenshots for reference.

As for the non-existent function, I can't recall how that happen but I got it to how it was.

HassanOHOsman · 2026-02-22T19:58:09Z

All done now. filtered out long blooms just before they're being send back to clients' browsers.

OracPrime

Prevention is better than cure!

OracPrime · 2026-02-22T22:23:38Z

backend/endpoints.py

    all_blooms = followed_blooms + own_blooms

+    # Filter long blooms (over 280 characters)
+    all_blooms = [bloom for bloom in all_blooms if len(bloom.content) <= MAX_BLOOM_LENGTH]


You're filtering blooms that are already in the backend that are over MAX_BLOOM_LENGTH but you're doing nothing to stop new ones being added.

I actually initially added a length checker inside the add_bloom function to make the logic future-proof. However, I then thought that from the client side users can’t go beyond 280 characters anyway. I know this isn’t the correct way to approach it, since someone could bypass the frontend and send a longer bloom directly to the server. I honestly focused solely on meeting the exact requirements of the quiz, which isn’t best practice. I know should fix not just the stated problem but also any potential loopholes that could cause issues in the future.

…ing created

HassanOHOsman · 2026-02-22T22:40:08Z

Done!

OracPrime

I think we've got there. Couple of comments to read/understand, but I think we can move on from this exercise. Remember: check on the way in, trust no-one.

OracPrime · 2026-02-22T23:37:33Z

backend/data/blooms.py

    hashtags = [word[1:] for word in content.split(" ") if word.startswith("#")]

    now = datetime.datetime.now(tz=datetime.UTC)
    bloom_id = int(now.timestamp() * 1000000)


This is sort of OK. But there are two better ways. Either investigate uuid.uuid4() or database autoincrement fields. In the context of this exercise, given that we're not going deep into databases, probably the uuid route.

Clearly this is nothing to do with the 280 char limit, so I mention this as a comment for your learning, not a request to fix it

HassanOHOsman · 2026-02-23T00:07:01Z

I think we've got there. Couple of comments to read/understand, but I think we can move on from this exercise. Remember: check on the way in, trust no-one.

Noted. Thank you very much!

HassanOHOsman added 2 commits February 17, 2026 14:28

Enforce 280-character limit on bloom submission

815e86b

Trim bloom content to 280 characters when rendering

98bc0a0

github-project-automation bot added this to Purple Forest Kanban Feb 17, 2026

github-project-automation bot moved this to Backlog in Purple Forest Kanban Feb 17, 2026

HassanOHOsman added ⚙️ bug Something isn't working Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module labels Feb 17, 2026

OracPrime suggested changes Feb 19, 2026

View reviewed changes

github-project-automation bot moved this from Backlog to In Progress in Purple Forest Kanban Feb 19, 2026

OracPrime added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 19, 2026

HassanOHOsman added 5 commits February 20, 2026 00:14

Remove all reference to logic that slice AS over 280 char bloom. This…

9e50343

… will later be replaced with a logic that fails the bloom altogeather.

reverting logic to where it was before adding new logic

4e9bbce

adding length-check for blooms being read from DB

f0605c1

Identify the bloom over 280 char by it's ID from the erros message in…

d3a5ba5

… the console. Use it to skip it while fetching all blooms from backend

Get AS bloom ID from the error on on console. Use it to skip of it wh…

6cf2872

…en blooms fetched from backend

replace bloom ID logic with condition to check if bloom over 280 char…

d3d20ad

…acters instead.

OracPrime added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 21, 2026

OracPrime suggested changes Feb 21, 2026

View reviewed changes

correct the function name

b2a455c

HassanOHOsman added 4 commits February 22, 2026 15:43

resetting branch to where it was by removing added logic in blooms.py

d1ab71d

add length check for when blooms are created

44e7568

resetting logic to start from main again

74503ed

filter out long blooms (over 280 char)

e05bd04

OracPrime suggested changes Feb 22, 2026

View reviewed changes

Add a measure to prevent any bloom longer than 280 characters from be…

03d0a63

…ing created

OracPrime approved these changes Feb 22, 2026

View reviewed changes

Uh oh!

Comments

Conversation

HassanOHOsman commented Feb 17, 2026

Uh oh!

OracPrime left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HassanOHOsman commented Feb 20, 2026

Uh oh!

HassanOHOsman commented Feb 20, 2026

Uh oh!

HassanOHOsman commented Feb 20, 2026

Uh oh!

OracPrime left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HassanOHOsman commented Feb 22, 2026

Uh oh!

OracPrime left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HassanOHOsman commented Feb 22, 2026

Uh oh!

OracPrime left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HassanOHOsman commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants