generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 36
Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 1 | Bug Report: Extra long blooms? #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HassanOHOsman
wants to merge
14
commits into
CodeYourFuture:main
Choose a base branch
from
HassanOHOsman:bugfix/bloom-over-280-characters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−0
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
815e86b
Enforce 280-character limit on bloom submission
HassanOHOsman 98bc0a0
Trim bloom content to 280 characters when rendering
HassanOHOsman 9e50343
Remove all reference to logic that slice AS over 280 char bloom. This…
HassanOHOsman 4e9bbce
reverting logic to where it was before adding new logic
HassanOHOsman f0605c1
adding length-check for blooms being read from DB
HassanOHOsman d3a5ba5
Identify the bloom over 280 char by it's ID from the erros message in…
HassanOHOsman 6cf2872
Get AS bloom ID from the error on on console. Use it to skip of it wh…
HassanOHOsman d3d20ad
replace bloom ID logic with condition to check if bloom over 280 char…
HassanOHOsman b2a455c
correct the function name
HassanOHOsman d1ab71d
resetting branch to where it was by removing added logic in blooms.py
HassanOHOsman 44e7568
add length check for when blooms are created
HassanOHOsman 74503ed
resetting logic to start from main again
HassanOHOsman e05bd04
filter out long blooms (over 280 char)
HassanOHOsman 03d0a63
Add a measure to prevent any bloom longer than 280 characters from be…
HassanOHOsman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're filtering blooms that are already in the backend that are over MAX_BLOOM_LENGTH but you're doing nothing to stop new ones being added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually initially added a length checker inside the add_bloom function to make the logic future-proof. However, I then thought that from the client side users can’t go beyond 280 characters anyway. I know this isn’t the correct way to approach it, since someone could bypass the frontend and send a longer bloom directly to the server. I honestly focused solely on meeting the exact requirements of the quiz, which isn’t best practice. I know should fix not just the stated problem but also any potential loopholes that could cause issues in the future.