fix(core): Restore original property descriptor on unregister#49
Open
jhnns wants to merge 1 commit intoGoncharukOrg:mainfrom
Open
fix(core): Restore original property descriptor on unregister#49jhnns wants to merge 1 commit intoGoncharukOrg:mainfrom
jhnns wants to merge 1 commit intoGoncharukOrg:mainfrom
Conversation
Fixes a potential "Maximum callstack size exceeded" error. The current implementation doesn't cleanup the defineProperty call on the element. For every register() call, a new object descriptor is created which calls the previous one and so on. After a lot of calls of register() and unregister(), the JS engine will finally throw a callstack size error.
Author
|
We stumbled upon this issue because we use a callback ref to set the // Simplified example
const inputRef = useMask({ /* ... */ });
return (
<input
ref={(element) => {
inputRef.current = element
}}
/>
);Since this passes a new function reference for every render, React calls the previous function with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a potential "Maximum callstack size exceeded" error. The current implementation doesn't cleanup the defineProperty call on the element. For every register() call, a new object descriptor is created which calls the previous one and so on. After a lot of calls of register() and unregister(), the JS engine will finally throw a callstack size error.