Skip to content

fix(core): Restore original property descriptor on unregister #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhnns wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core): Restore original property descriptor on unregister #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/core/src/Input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export default class Input<T = unknown> {

constructor({ init, tracking }: InputOptions<T>) {
const handlersMap = new WeakMap<HTMLInputElement, ContextValue>();
const descriptorMap = new WeakMap<HTMLInputElement, PropertyDescriptor | undefined>();

this.register = (element) => {
if (!ALLOWED_TYPES.includes(element.type)) {
Expand Down Expand Up @@ -72,6 +73,7 @@ export default class Input<T = unknown> {
// Поскольку значение элемента может быть изменено вне текущей логики,
// нам важно перехватывать каждое изменение для обновления `tracker.value`.
// `tracker.value` служит заменой `_valueTracker.getValue()` предоставляемый React.
descriptorMap.set(element, descriptor);
Object.defineProperty(element, 'value', {
...descriptor,
set: (value: string) => {
Expand Down Expand Up @@ -240,6 +242,16 @@ export default class Input<T = unknown> {
};

this.unregister = (element) => {
const descriptor = descriptorMap.get(element);

if (descriptor !== undefined) {
const { value } = element;

Object.defineProperty(element, 'value', descriptor);
descriptorMap.delete(element);
element.value = value;
}

const handlers = handlersMap.get(element);

if (handlers !== undefined) {
Expand Down