#2125: Fix error: format string is not a string literal (#2126) #2126
+1
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reasons, `std::string StrFormat(const char* format, ...)` was declared with castom format attributes in conditions. The project wide macro `PRINTF_FORMAT_STRING_FUNC` must be used.
sergio-nsk
changed the title
Member
|
test failure is unrelated. i'm a little concerned that this approach won't work on all platforms, but it's passing CI/CD so LGTM |
dmah42
approved these changes
Feb 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reasons,
std::string StrFormat(const char* format, ...)was declared with castom format attributes in conditions. The project wide macroPRINTF_FORMAT_STRING_FUNCmust be used.