tests: Mock arweave resolver to fix flaky arweave_file_data_sources test#6363
Open
tests: Mock arweave resolver to fix flaky arweave_file_data_sources test#6363
arweave_file_data_sources test#6363Conversation
The test relied on real HTTP calls to arweave.net and a 1500ms sleep hack to work around the resulting race condition. Replace with a StaticArweaveResolver that returns synthetic content from memory, making the test deterministic and faster. Also generalize arweave_service() to accept Arc<dyn ArweaveResolver> instead of Arc<ArweaveClient>, and ensure setup_inner uses a single resolver instance for both the polling service and TestContext.
dimitrovmaksim
approved these changes
Feb 14, 2026
Member
dimitrovmaksim
left a comment
dimitrovmaksim
left a comment
There was a problem hiding this comment.
LGTM. The only nit I had initially was the use of ArweaveClientError::UnableToCheckFileSize error variant in get_with_limit, but it seems there isn't another option, with Unknown being too ambiguous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test relied on real HTTP calls to arweave.net and a 1500ms sleep hack to work around the resulting race condition. Replace with a
StaticArweaveResolverthat returns synthetic content from memory, making the test deterministic and faster.Also generalize
arweave_service()to acceptArc<dyn ArweaveResolver>instead ofArc<ArweaveClient>, and ensuresetup_inneruses a single resolver instance for both the polling service andTestContext.